Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unnecessary dep #2492

Merged
merged 1 commit into from
Sep 19, 2023
Merged

fix: remove unnecessary dep #2492

merged 1 commit into from
Sep 19, 2023

Conversation

Zsynuting
Copy link
Contributor

在monorepo 的 root 中已经将 @alilc/build-plugin-lce 作为 devDeps 了，这里直接删掉就可以了

@CLAassistant
Copy link

CLAassistant commented Sep 18, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Zsynuting Zsynuting mentioned this pull request Sep 18, 2023
Closed
@JackLian
Copy link
Collaborator

CLA麻烦签一下

@JackLian
Copy link
Collaborator

目标分支改成 develop

@Zsynuting Zsynuting changed the base branch from main to develop September 18, 2023 07:59
@Zsynuting
Copy link
Contributor Author

sorry，改了

@codecov
Copy link

codecov bot commented Sep 18, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (bf980c9) 85.21% compared to head (b414468) 85.21%.
Report is 20 commits behind head on develop.

❗ Current head b414468 differs from pull request most recent head 82aaf33. Consider uploading reports for the commit 82aaf33 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #2492   +/-   ##
========================================
  Coverage    85.21%   85.21%           
========================================
  Files          222      222           
  Lines         8947     8947           
  Branches      2099     2099           
========================================
  Hits          7624     7624           
  Misses        1234     1234           
  Partials        89       89

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JackLian
Copy link
Collaborator

https://lowcode-engine.cn/site/docs/faq/faq021
CLA还有问题，参考下这个

@Zsynuting
Copy link
Contributor Author

https://lowcode-engine.cn/site/docs/faq/faq021 CLA还有问题，参考下这个

OK

@Zsynuting
Copy link
Contributor Author

https://lowcode-engine.cn/site/docs/faq/faq021 CLA还有问题，参考下这个

现在没问题了，对吧？

@JackLian JackLian merged commit 3658bac into alibaba:develop Sep 19, 2023
@open-digger-bot open-digger-bot bot mentioned this pull request Sep 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liujuping liujuping Awaiting requested review from liujuping liujuping is a code owner

@JackLian JackLian Awaiting requested review from JackLian JackLian is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zsynuting @CLAassistant @JackLian